Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for CA1868 #36379

Merged
merged 7 commits into from
Jul 28, 2023
Merged

Add documentation for CA1868 #36379

merged 7 commits into from
Jul 28, 2023

Conversation

mpidash
Copy link
Contributor

@mpidash mpidash commented Jul 25, 2023 •
edited by github-actions bot
Loading

@mpidash mpidash requested review from gewarren and a team as code owners July 25, 2023 00:21
@dotnet-bot dotnet-bot added this to the July 2023 milestone Jul 25, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Jul 25, 2023
@gewarren gewarren added the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Jul 25, 2023
gewarren
gewarren reviewed Jul 25, 2023
View reviewed changes
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the docs @mpidash!

docs/fundamentals/code-analysis/quality-rules/ca1865.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/ca1865.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/ca1865.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/index.md Outdated Show resolved Hide resolved
docs/fundamentals/code-analysis/quality-rules/performance-warnings.md Outdated Show resolved Hide resolved
mpidash and others added 3 commits July 25, 2023 11:30
@mpidash @gewarren
Apply suggestions from code review
3345e26 
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
@mpidash
Add space
3635ae1
@mpidash
Apply previous changes to index files
e055b1c
@gewarren gewarren changed the title Add documentation for CA1865 Add documentation for CA1868 Jul 27, 2023
@gewarren
Copy link
Contributor

@mpidash Looks like the rule ID needs to be updated to CA1868.

@mpidash mpidash requested a review from gewarren July 28, 2023 00:32
@gewarren gewarren removed the 🚧 Hold for related PR Indicates a PR can only be merged when other related PRs are merged (see comments for links) label Jul 28, 2023
@gewarren gewarren merged commit 04d0f2b into dotnet:main Jul 28, 2023
7 checks passed
@mpidash mpidash deleted the ca1865 branch July 29, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gewarren gewarren gewarren approved these changes

Assignees
No one assigned
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Milestone
July 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@mpidash @gewarren @dotnet-bot